Add documentation for tracing.sampling-ratio configuration property#28541
Open
hashroute3 wants to merge 3 commits intotrinodb:masterfrom
Open
Add documentation for tracing.sampling-ratio configuration property#28541hashroute3 wants to merge 3 commits intotrinodb:masterfrom
hashroute3 wants to merge 3 commits intotrinodb:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Mahendran Vasagam.
|
hashroute3
force-pushed
the
doc/add-tracing-sampling-ratio-config
branch
from
0b40bfc to
46eb971
Compare
ebyhr
reviewed
Mar 5, 2026
hashroute3
force-pushed
the
doc/add-tracing-sampling-ratio-config
branch
from
2894aba to
5414b82
Compare
Member
Author
|
@ebyhr Thank you for the review! I’ve addressed all the feedback you shared. |
kekwan
approved these changes
Mar 12, 2026
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Document the
otel.tracing.sampling-ratioconfiguration property in the OpenTelemetry tracing documentation. This property already exists in the AirliftOpenTelemetryConfigclass and controls the ratio of traces that are sampled and exported, but was not documented in the Trino docs.Additional context and related issues
When tracing is enabled with the default sampling ratio of
1(100%), high-traffic Trino deployments can generate excessive trace events, causing high load and cost on observability backends (e.g. Honeycomb, Jaeger). The workaround today is running an OpenTelemetry collector sidecar with sampling configuration, which adds unnecessary operational complexity.Documenting
otel.tracing.sampling-ratioallows users to reduce trace volume directly in Trino'sconfig.propertieswithout external workarounds.The property is confirmed visible in Trino bootstrap logs:
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: